[squid-dev] [PATCH] Extend SBufContainerJoin to have prefix and suffix arguments

Alex Rousskov rousskov at measurement-factory.com
Fri Nov 11 17:59:52 UTC 2016

On 11/10/2016 01:28 PM, Kinkie wrote:

> +/// convenience wrapper of JoinContainerIntoSBuf with no caller-supplied SBuf
> +template <class ContainerIterator>
> +SBuf
> +JoinContainerToSBuf(const ContainerIterator &begin,

IMO, the description should disclose the performance overhead of the
convenience wrapper [instead of stating the obvious lack of the
caller-supplied SBuf]. I have proposed a specific wording, but it does
not have to be that wording, of course.

> v4 attached.

v5, actually.

I am OK with these changes going in, hopefully after the description
adjustment discussed above.

Thank you,


More information about the squid-dev mailing list