[squid-dev] [PATCH] Segfault via Ftp::Client::readControlReply.
christos at chtsanti.net
Fri Nov 11 16:45:01 UTC 2016
On 11/11/2016 06:36 PM, Christos Tsantilas wrote:
> The patch applied to trunk as r14936 and r14937.
I mean applied to "squid-5".
> I am attaching a patch for squid-3.5 release.
> On 11/11/2016 07:37 AM, Amos Jeffries wrote:
>> On 11/11/2016 6:03 a.m., Christos Tsantilas wrote:
>>> Added nil dereference checks for Ftp::Client::ctrl.conn, including:
>>> - Ftp::Client::handlePasvReply() and handleEpsvReply() that dereference
>>> ctrl.conn in DBG_IMPORTANT messages.
>>> - Many functions inside FtpClient.cc and FtpGateway.cc files.
>>> TODO: We need to find a better way to handle nil ctrl.conn. It is only a
>>> matter of time when we forget to add another dereference check or
>>> discover a place we missed during this change.
>>> Also disabled forwarding of EPRT and PORT commands to origin servers.
>>> Squid support for those commands is broken and their forwarding may
>>> cause segfaults (bug #4004). Active FTP is still supported, of course.
>>> This is a Measurement Factory project.
>> in ftpReadPasv()
>> - please leave the ftpSendEPRT where it was (but comment out). As-is
>> this will just add a new Coverity issue about dead/unreachable code.
>> in completeForwarding()
>> - sic you are changing the debugs line please polish it all up to remove
>> the HERE
>> - also s/completeForwarding avoids /avoid /
>> +1 with the above polish.
>> pPS. please remember to apply on the squid-5 branchnow, not trunk or v4.
>> squid-dev mailing list
>> squid-dev at lists.squid-cache.org
More information about the squid-dev