[squid-dev] [PATCH] Segfault via Ftp::Client::readControlReply.

Christos Tsantilas christos at chtsanti.net
Thu Nov 10 17:03:58 UTC 2016

Added nil dereference checks for Ftp::Client::ctrl.conn, including:
- Ftp::Client::handlePasvReply() and handleEpsvReply() that dereference 
ctrl.conn in DBG_IMPORTANT messages.
- Many functions inside FtpClient.cc and FtpGateway.cc files.

TODO: We need to find a better way to handle nil ctrl.conn. It is only a 
matter of time when we forget to add another dereference check or 
discover a place we missed during this change.

Also disabled forwarding of EPRT and PORT commands to origin servers. 
Squid support for those commands is broken and their forwarding may 
cause segfaults (bug #4004). Active FTP is still supported, of course.

This is a Measurement Factory project.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: SQUID-233-Squid_Segfault_via_Ftp_Client_readControlReply-t4.patch
Type: text/x-patch
Size: 16020 bytes
Desc: not available
URL: <http://lists.squid-cache.org/pipermail/squid-dev/attachments/20161110/a2053526/attachment.bin>

More information about the squid-dev mailing list