[squid-dev] [PATCH] Delete cbdata-protected data --with-valgrind-debug

Amos Jeffries squid3 at treenet.co.nz
Wed May 18 19:14:03 UTC 2016

On 18/05/2016 6:22 p.m., Alex Rousskov wrote:
> Hello,
>     Valgrind was correctly reporting every cbdata allocation in trunk as
> leaking! AFAICT, these regressions were introduced by a combination of
> trunk r13977 (Bug 4215: double-free in CBDATA) and trunk r13909
> (de-duplicate cbdata deallocate actions). These cbdata-protected data
> leaks were not present when Squid was built without valgrind support.
> I also fixed and polished cbdata debugging that was printing mismatching
> Allocating/Freeing pointer values and synced scripts/find-alive.pl.

Great.  +1 and please apply.

> The surrounding code needs a lot more love than I can currently give it,
> but I hope that the attached fixes do not create new problems.

I think other than bug fixes like this our efforts should go towards
AsyncCall and AsyncJob conversions.


More information about the squid-dev mailing list