[squid-dev] HttpHeader::delById leaks

Alex Rousskov rousskov at measurement-factory.com
Wed May 18 05:33:23 UTC 2016

On 05/04/2016 10:58 AM, Alex Rousskov wrote:
>     AFAICT, the following trunk code leaks every "deleted" header field:
> The leak was created in trunk r14285 dated 2015-09-05: Refactor
> HttpHeader into gperf-generated perfect hash.

> Please fix if you can.

Since trunk r14659 (HTTP/1.1: normalize Host header), Squid has been
leaking one header entry on virtually every request because of this bug.

This bug also corrupted HttpHeader::len value whenever a header field
was deleted.

Ironically, the broken changes were actually outside the claimed gperf
optimization scope AFAICT.

I restored the old delById() code (essentially) in trunk r14668.



More information about the squid-dev mailing list