[squid-dev] [PATCH] Ensure any previous value in lastAclData is free'd

[Amos Jeffries]

On 11/03/2016 11:56 a.m., Nathan Hoad wrote:
> Hello,
> 
> Attached is a patch that ensures lastAclData doesn't leak any data,
> exactly the same as lastAclName.
> 
> In my testing, this wasn't leaking very much memory, but a leak regardless.
> 

+1.

Since the 'sb' variable it's being set from is an SBuf, and the format
codes can now handle SBuf too - would you mind taking a stab at making
lastAclData itself an SBuf?
 That should get rid of some data-copy cycles and handle any related
leaks hiding elsewhere.

(just a request, if not that is fine and this can go in instead).

Amos