[squid-dev] [PATCH] Use TCP_REFRESH_PENDING while waiting for IMS reply

[Amos Jeffries]

On 1/06/2016 8:17 a.m., Eduard Bagdasaryan wrote:
> Hello,
> 
> This patch marks refresh-waiting transactions with TCP_REFRESH_PENDING.
> 
> Before this change, transactions initiating a refresh were still marked
> as TCP_HIT*. If such a transaction was terminated (for any reason)
> before receiving an IMS reply, it was logged with that misleading tag.
> Now, such transactions are logged using TCP_REFRESH_PENDING[_ABORTED].
> 
> After the refresh (successful or otherwise), the tag changes to one of
> the other TCP_REFRESH_* values, as before.

I am planing to make the tags into a bunch of flags that get set
individually by the relevant code. So the logged details would get
incrementally built up, much like this code is doing for the visible
behaviour of REFRESH action.

But to fit with that properly this should be called just "TCP_REFRESH".

If there are no objections I will apply with that name change in ~24hrs.

Amos