[squid-dev] [PATCH] Some failed transactions are not logged

[Amos Jeffries]

On 19/07/2016 11:56 p.m., Eduard Bagdasaryan wrote:
> Addressed discussion concerns and refreshed the patch.
> 
> 2016-07-19 8:13 GMT+03:00 Amos Jeffries:
>> Is ftp_port traffic another one?
> 
> IMO this is not a case because Ftp::Server (similarly to Http::One::Server)
> cares about inBuf consumtion and ClientHttpRequest objects creation.
> 

Okay. Thanks.

One remainign bug question:

 Is this patch going to include the new config option to prevent logging
the new things? or do it in a followup?


Plus three very minor things that can be done on commit:

* the accept(2) errors and its release notes
  - s/accept-user-conn/accept-client-conn/

* The XXX about PROXY protocol, should be that it _is_ going through
inBuf and counted as receivedFirstByte_. So will not logged, even though
it should.
 - one-liner maybe: 'XXX: The PROXY protocol counts against
receivedFirstByte_, so early close not logged.'

* nullptr instead of NULL in logAcceptError().

+1 for the code currently in the patch. Pending the question of new
config option.


Amos