[squid-dev] [PATCH] securiy_fake_certv ; aka helpers/ shuffling exemplar

[Alex Rousskov]

On 01/28/2016 06:55 AM, Amos Jeffries wrote:
> This patch demonstrates my proposed helpers/ shuffling by updating the
> demo certificate validator.
> 
> * creates src/security/certv/ for certificate validation helpers.
>  To distinguish from certificate generator helpers which would be in
> src/security/certg/.

Please consider using more than one letter to distinguish directories
(e.g., cert_gen and cert_validators).


> +(C) 2012 The Measurement Factory, Author: Tsantilas Christos

If it helps, you may use the standard Squid boilerplate for Factory
files and avoid a special CREDITS mention.


> +	<p>One <em>fake</em> helper that it does not actually perform any
> +	   certificate checks is provided for testing and example code for writing
> +	   custom helpers.

s/that it does/that does/
s/and example code for/and as an example for/
s/custom helpers/real validators/


I did not audit the path but have no objections (with or without the
above polishing touches).


Thank you,

Alex.