[squid-dev] checklist->conn assertion in DestinationIp.cc

Eduard Bagdasaryan eduard.bagdasaryan at measurement-factory.com
Mon Jan 11 17:54:58 UTC 2016


Hello,

Attaching patch with suggested fix. The fix is
related to bug 4378.

Eduard.

On 19.07.2015 11:10, squid3 at treenet.co.nz (Amos Jeffries) wrote:
> On 19/07/2015 3:26 p.m., Alex Rousskov wrote:
>> How about the following two changes?
>>
>> 1. Change FilledChecklist::conn() to return NULL when conn_ is invalid.
>> 2. Change the above assertion into an if statement, returning -1.
>>
>>
>> If, after the above is done, somebody volunteers to replace the raw
>> conn_ pointer with a CbcPointer, they should be welcomed to do that, of
>> course.
>
> SGTM. +1.
>
> Amos
>
>
> Amos
>

-------------- next part --------------
A non-text attachment was scrubbed...
Name: SQUID-37-assertion-in-destination-ip-t1.patch
Type: text/x-patch
Size: 4754 bytes
Desc: not available
URL: <http://lists.squid-cache.org/pipermail/squid-dev/attachments/20160111/13830b97/attachment-0001.bin>


More information about the squid-dev mailing list