[squid-dev] [PATCH] improve CharacterSet

Amos Jeffries squid3 at treenet.co.nz
Mon Jan 4 05:56:20 UTC 2016


On 3/01/2016 7:11 a.m., Alex Rousskov wrote:
> On 01/02/2016 06:52 AM, Kinkie wrote:
> 
>>   the code is polished and ready to be merged. unfortunately I hit a
>> snag while trying to actually make use of it: helpers can rely on code
>> in lib/, but not in src, due to the order subdirectories are built.
>>
>> I've thus changed order of subdirs in the top-level Makefile.am so
>> that src/ is built before helpers; we have a similar dependency for
>> tools/, we need to remember this.
> 
> This build order change should not be a part of the "improve
> CharacterSet" patch because it has nothing to do with improving
> CharacterSet API. Whether helpers are allowed to use src/ is a separate
> question, implicitly being discussed on the "SBuf API" thread right now.

Aye. Reverting the SUBDIRS change that got applied in rev.14472.

I notice that DIST_SUBDIRS and SUBDIRS have a mismatch with the ordering
of test-suite and tools directories. That may be causing some build or
packaging oddities, and IMO should be fixed too if we can agree on best
way to do that.

Amos



More information about the squid-dev mailing list