[squid-dev] [PATCH] Incorrect processing of long URIs

Amos Jeffries squid3 at treenet.co.nz
Sat Aug 27 13:56:14 UTC 2016

On 26/08/2016 5:43 a.m., Alex Rousskov wrote:
> On 08/25/2016 10:26 AM, Amos Jeffries wrote:
>> About
>> the only further optimization we can do there is make the
>> "CharacterSet::SP" that it outputs in the sensitive path be a local
>> static *within* DelimiterCharacters() itself and return a reference to
>> that instead of constructing a new CharaterSet each time.
> Which new CharaterSet are we constructing each time in this context?
> CharacterSet::SP is already a static and it is not copied during each
> DelimiterCharacters() call, right? SP might not be initialized, but I do
> not see an _optimization_ opportunity here.

Doh. You are right. I was thinking it was a local.
Thanks for the commit.


More information about the squid-dev mailing list