[squid-dev] [PATCH] Incorrect processing of long URIs

Alex Rousskov rousskov at measurement-factory.com
Thu Aug 25 17:33:47 UTC 2016


On 08/25/2016 10:26 AM, Amos Jeffries wrote:
> 2016-08-23 17:50 GMT+03:00 Alex Rousskov:
>> I wonder whether we should make this variable static to avoid repeated
>> function calls on a performance-sensitive code path.


> The output of DelimiterCharacters() cannot be stored in a static because
> it possibly changes with a reconfigure.

Agreed. My suggestion was wrong.


> Other than that it looks okay to me. +1.
>  Alex can you apply please with the above taken care of?

Committed to trunk (r14815).


Thank you,

Alex.



More information about the squid-dev mailing list