[squid-dev] [PATCH] Revalidate without Last-Modified

Eduard Bagdasaryan eduard.bagdasaryan at measurement-factory.com
Sat Aug 20 21:08:05 UTC 2016


This patch fixes bug 4471.

The bug was caused by the fact that Squid used only Last-Modified header
value for evaluating entry's last modification time while making an
internal revalidation request. So, without Last-Modified it was not
possible to correctly fill If-Modified-Since header value. As a result,
the revalidation request was not initiated when it should be.

To fix this problem, we should generate If-Modified-Since based on other
data, showing how "old" the cached response is, such as Date and Age
header values.  Both Date and Age header values are utilized while
calculating entry's timestamp.  Therefore, we could use the timestamp if
Last-Modified is unavailable.

XXX: HttpRequest::imslen support looks broken/deprecated. Using this
field inside StoreEntry::modifiedSince() leads to several useless checks
and probably may cause other [hidden] problems.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: SQUID-209-revalidate-without-last-modified-t1.patch
Type: text/x-patch
Size: 62690 bytes
Desc: not available
URL: <http://lists.squid-cache.org/pipermail/squid-dev/attachments/20160821/f18d3920/attachment-0001.bin>

More information about the squid-dev mailing list