[squid-dev] [PATCH] Ipc::MemMap::ttl removal

Alex Rousskov rousskov at measurement-factory.com
Mon Aug 8 23:09:20 UTC 2016


On 08/08/2016 08:12 AM, Amos Jeffries wrote:
> Coverity Scan latest checks are reporting that the ttl member of
> Ipc::MemMap is being left uninitialized.
> 
> It sounds like something which would lead to major bugs. Except that it
> turns out, AFAICS, that this ttl member is never actually being used.
> 
> Anyone have a reason not to simply drop it from the code?

There cannot be valid reasons to keep unused code for more than a year.
Please remove it.

FWIW, I bet it is just accidental leftovers from some earlier MemMap design.

Alex.



More information about the squid-dev mailing list