[squid-dev] [PATCH] libmem API cleanup pt2
rousskov at measurement-factory.com
Wed Apr 20 15:06:52 UTC 2016
On 04/12/2016 05:31 AM, Amos Jeffries wrote:
> This is the first of the followup patches I promised when applying the
> un-polished bug 4438 patch to 4.0.8.
> Convert all the objects using the libmem "old API" for as-needed pools
> to using the MEMPROXY_CLASS() API which is better designed for late
I am unable to review these code shuffling changes efficiently so please
do not count on my feedback. I do agree with Kinkie that there is no
reason to violate class naming conventions, especially by using
underscore-prefixed class names.
> The GetPool(type) function is now guaranteed to produce a
> pre-initialized pool for all valid pool types. Except in the case where
> it is recursively being used by Mem::Init() to perform that initialization.
AFAICT, there is [still] no such guarantee in code. What we write in
emails is not that important in this case.
More information about the squid-dev