[squid-dev] [PATCH] Replace new/delete operators using modern C++ rules
rousskov at measurement-factory.com
Mon Apr 11 15:16:18 UTC 2016
On 04/09/2016 10:50 PM, Amos Jeffries wrote:
> In principle this is a great step forward, but I would like confirmation
> about the portability side of things before it actually gets merged.
Me too. However, please keep in mind that beyond [unlikely] compilation
failures, it would be difficult for non-developers to confirm that the
patch does not break anything, especially without somebody writing
detailed instructions on how to do that: AFAICT, the code in question
does not affect any functionality that is both enabled by default and
visible in Squid logs or responses.
FWIW, the patch did compile fine on a few Linux boxes and one MacOS laptop.
It would also be great to test whether the clang exclusion was motivated
by the same outdated (or even wrong) reasons as the other hacks around
this code -- we may be able to remove that last exclusion if those tests
are successful. Again, this will require a person who knows how to read
Valgrind reports and can test --enable-xmalloc-statistics effects.
More information about the squid-dev