[squid-dev] [PATCH] Remove ServerOptions "partial copy" copy constructor

Amos Jeffries squid3 at treenet.co.nz
Thu Apr 7 09:22:02 UTC 2016


On 7/04/2016 6:10 p.m., Alex Rousskov wrote:
> Hello,
> 
>     The attached patch removes broken and, AFAICT, unused "partial copy"
> ServerOptions copy constructor.
> 
> I am not intimate with the affected code, so more work may be needed
> around this change: If the partial copy constructor was meant to be
> abused for something, then a new approach should be found for that use
> case -- an approach that does not violate the standard copy constructor
> post-conditions.

A (full) copy-constructor is needed on some systems for the clear()
method implementation to build.

Amos



More information about the squid-dev mailing list