[squid-dev] [PATCH] Increase request buffer size to 64kb

Nathan Hoad nathan at getoffmalawn.com
Fri Apr 1 05:22:57 UTC 2016

I've attached two patches - they're functionally identical, one uses
SBuf and the other using MemBuf. The patch achieves the following:

 - Moves all of Http::Stream's uses of StoreIOBuffer objects into a
method, as done previously.
 - Adjusts the read_ahead_gap default to 64 KB as Amos suggested.
 - Replaces Http::Stream::reqbuf with a SBuf/MemBuf.
 - Make the buffer member private.
 - Adds a new configuration option for the size of the buffer, with a
default of 64 KB, in the spirit of the original patch.

I'm not convinced that http_stream_buffer_size is the best name, but I
can't think of anything better. The patches are also abusing
MemBuf/SBuf - they're being used purely to allow configuration of the
buffer size, they're not being used as they normally are, or growing
dynamically. That would involve quite a few more changes, I think.

Thank you,


On 1 April 2016 at 03:20, Alex Rousskov
<rousskov at measurement-factory.com> wrote:
> On 03/31/2016 04:45 AM, Amos Jeffries wrote:
>> PS. If you like I will take your current patch and merge it tomorrow.
> Please do not do that until others have a chance to review the results.
> Alex.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: recv-buffer-v3-sbuf.patch
Type: text/x-patch
Size: 5432 bytes
Desc: not available
URL: <http://lists.squid-cache.org/pipermail/squid-dev/attachments/20160401/9bff2682/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: recv-buffer-v3-membuf.patch
Type: text/x-patch
Size: 5424 bytes
Desc: not available
URL: <http://lists.squid-cache.org/pipermail/squid-dev/attachments/20160401/9bff2682/attachment-0001.bin>

More information about the squid-dev mailing list