[squid-dev] [PATCH] Refactor htcpDetail into MEMPROXY_CLASS

[Kinkie]

On Mon, Sep 28, 2015 at 10:10 AM, Amos Jeffries <squid3 at treenet.co.nz> wrote:
> On 28/09/2015 7:28 p.m., Kinkie wrote:
>> Whoops, sorry.
>> The patch includes spurious changes.
>> Updated patch attached.
>>
>
> +1.  Though please fix the indentation on "delete d;" in chunk @1100.
> Which should be 4 not 8 SP.

Huh?
code is:
    if (d)
        delete d;

Indentation looks legitimate to me..

BTW: there is a substantial difference in the memproxy_class behavior
wrt standard "delete": AFAICS, "delete nullptr" is a perfectly
legitimate statement by the standard and it is a NOP. When going
through mempools, it reaches MemImplementingAllocator::freeOne which
asserts. would it make sense to NOP ourselves?

-- 
    Francesco