[squid-dev] [PATCH] neutralize gperf useage of "register" keyword

Kinkie gkinkie at gmail.com
Tue Sep 22 17:06:35 UTC 2015


Hi,
  due to the impossibility to expand target variables. the wrapped
lines are over 80 chars anyway, so readability doesn't improve in this
case . I'm therefore committing as-is.

On Tue, Sep 22, 2015 at 6:41 PM, Kinkie <gkinkie at gmail.com> wrote:
> I had encountered issues with multiline. Maybe the root cause was spurious.
>
> On Tue, Sep 22, 2015 at 6:37 PM, Amos Jeffries <squid3 at treenet.co.nz> wrote:
>> On 23/09/2015 4:30 a.m., Kinkie wrote:
>>> Hi,
>>>    revised patch attached.
>>>
>>> On Tue, Sep 22, 2015 at 5:28 PM, Amos Jeffries <squid3 at treenet.co.nz> wrote:
>>>> On 23/09/2015 3:16 a.m., Kinkie wrote:
>>>>> Hi,
>>>>>   "register" is a deprecated keyword in c++11, and clang-3.5 is
>>>>> enforcing that with our flags.
>>>>> The attached patch neutralizes this behavior with a local #define;
>>>>> it'll be needed until gperf catches up with the standards.
>>>>> build-tested.
>>>>
>>>> It would be a bit safer to sed the output of gperf in the makefile.
>>>>
>>
>> +1.
>>
>> Though do you really have to write the makefile commands all in one line
>> ?  things seem to be fine with the '\' line wrappings making things more
>> readable in other files.
>>
>> Amos
>>
>
>
>
> --
>     Francesco



-- 
    Francesco


More information about the squid-dev mailing list