[squid-dev] [PATCH] %<lp missing for persistent connections

Alex Rousskov rousskov at measurement-factory.com
Wed Oct 21 03:42:42 UTC 2015


Hello,

    Connection stats, including %<lp, were missing for persistent
connections.

The code reusing a pconn was missing a hier.note() call, resulting in 0
values logged for %<lp (local port number of the last server or peer
connection) and probably other missing stats.

Also refactored poorly copied statistics collection code to remove
duplication and always update to-server connection stats when the actual
connection becomes available.

Positive side effect: Upon setsockopt(2) failures, the tos and nfmark
fields of a pinned connection were set to the desired (but not actually
applied) values, while persistent connection fields were left intact
(and, hence, stale). Both fields are now reset to zero on failures, for
both types of connections.


HTH,

Alex.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: SQUID-106-intermittent-0-outgoing-port-t3.patch
Type: text/x-diff
Size: 14732 bytes
Desc: not available
URL: <http://lists.squid-cache.org/pipermail/squid-dev/attachments/20151020/9d8d4016/attachment.patch>


More information about the squid-dev mailing list