[squid-dev] [PATCH] Store API changes blocking bug #7

Kinkie gkinkie at gmail.com
Thu Nov 19 06:26:36 UTC 2015

On Thu, Nov 19, 2015 at 7:03 AM, Alex Rousskov
<rousskov at measurement-factory.com> wrote:
> On 11/18/2015 01:03 AM, Amos Jeffries wrote:
>> * in src/fs/ufs/UFSSwapDir.h and src/tests/TestSwapDir.h (at least) you
>> have one class with a mix of override/non-override virtuals.
>>  - Kinkie and I have found the hard way earlier that some compilers
>> error if only some virtual methods in a class heirarchy are marked with
>> it. It is an all-or-nothing per-heirarchy situation with that keyword.
> If it was an error (and not just a warning), then that sounds like a
> broken compiler to me. Said that, "apply specifiers consistently" is a
> good general rule, of course. I ignored that rule to minimize
> unnecessary old code changes.

It may have been a warning, but as we build with -Werror, it gets
promoted to error.

> Overall, enforcing consistent override use looks like a whole project on
> its own! ]

Yes, with all the downsides of flag-day commits etc.

> Committed to trunk (r14411).

Good; thanks!


More information about the squid-dev mailing list