[squid-dev] [PATCH] ignore build-generated files

[Amos Jeffries]

On 13/11/2015 4:04 a.m., Alex Rousskov wrote:
> On 11/11/2015 08:54 PM, Amos Jeffries wrote:
>> On 12/11/2015 10:41 a.m., Alex Rousskov wrote:
>>> Hello,
>>>
>>>     The attached patch tells bzr to ignore most build-generated files.
>>> This is very helpful when reorganizing Squid sources and not using
>>> out-of-source builds.
>>>
>>> Most of the new entries were produced by appending "bzr status" output
>>> on an otherwise clean tree after a build. I am surprised nobody
>>> committed something like that before so perhaps I am missing some
>>> caveats here?
>>
>> What you seem to be missing is that if updating a Makefile.am or
>> configure.ac (eg. with bzr update) to remove the generated file. Then a
>> following "make clean" or even distclean will not remove the old files
>> from the build area. This will keep them hidden and possible affecting
>> the build for people who may not be aware of the change.
> 
> Two people sharing the same build directory?


I mean anyone building in-tree and then using "bzr update" on that tree.
If they dont remember to run "make distclean" before next bootstrap
trouble happens.

By not having the built files ignored one can just run "bzr clean-tree"
to purge then re-bootstrap.


> Even if we assume this is
> an important use case, it does not seem to be relevant here -- the
> current .bzrignore results in hundreds of files reported as unknown. A
> small change in that very long list will not be noticeable today.
> Perhaps I misunderstood the use case you are describing.

> 
> 
>> It can also hide makefile mistakes between $srcdir and $builddir or the
>> matching top_* variables if the developer changing the makefile is
>> working in-tree.
> 
> Or it can show those mistakes.
> 
> 
>> PS. I found Henriks advice years ago never to use in-tree builds to be a
>> good rule to work by and never looked back. These files are not a
>> problem when working out-or-tree, all we see in "bzr status" is the top
>> build directory.
> 
> Sure, but including more files into .bzrignore does not hurt those who
> need to work out-of-tree.
> 
> 
> So what is the current policy of adding X into .bzrignore?

We don't have one AFAIK.


Up to ou whether you commit. I'm just answering your "what am I
missing?" question.

Amos