[squid-dev] [PATCH] Consistently apply notes from cached external ACL replies

[Nathan Hoad]

Hello,

Attached is a patch that adds notes from cached ACL helpers to request objects.

Without this patch, when you have an external ACL that replies with
notes, they are only added onto the HTTP request that kicked off the
external ACL lookup, and not cached ACL responses. This means if you
set notes from an external ACL that are used for some processing in
other ACLs, or post-processing on logs, things may be missed.

To illustrate what I mean...

external_acl_type foo %DST /path/to/fakehelper.py
acl foo external foo
http_access allow foo

logformat foolog %ru %note %et
access_log /path/to/access.log foolog

fakehelper is a script that always replies with "OK tag=fromacl
foo=bar bar=baz".

Access log prior to the patch:

http://google.com/ foo:%20bar%0D%0Atag:%20fromacl%0D%0Abar:%20baz%0D%0A fromacl
http://google.com/ - fromacl

Access log after the patch:

http://google.com/ foo:%20bar%0D%0Atag:%20fromacl%0D%0Abar:%20baz%0D%0A fromacl
http://google.com/ foo:%20bar%0D%0Atag:%20fromacl%0D%0Abar:%20baz%0D%0A fromacl

Thank you,

Nathan.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: apply-cached-notes.patch
Type: text/x-patch
Size: 1382 bytes
Desc: not available
URL: <http://lists.squid-cache.org/pipermail/squid-dev/attachments/20150508/b6e38fb7/attachment.bin>