[squid-dev] [PATCH] CompactTrie

Alex Rousskov rousskov at measurement-factory.com
Fri Mar 20 16:33:01 UTC 2015


On 03/20/2015 09:36 AM, Kinkie wrote:

>   the attached bundle is a patch proposal for CompactTrie, a generic
> library implementing efficient prefix matching.
>    It is meant to be a more feature-complete replacement for
> lib/libTrie, and has the machinery to effectively replace splay when
> doing dstdomain-type lookups.


I do not recommend committing unused code, but will not block this
commit if others think it is a good idea. If possible, I suggest waiting
until something starts using this code.


> +/** Private auxiliary class for CompactTrie.
> + *
> + * DO NOT USE or try to access it in any other context.
> + */
> +template <class Key, class Value>
> +class CompactArrayTrieNode


If possible, please document what this class actually is (in addition to
documenting its users and prohibiting other users).


Thank you,

Alex.



More information about the squid-dev mailing list