[squid-dev] checklist->conn assertion in DestinationIp.cc

Amos Jeffries squid3 at treenet.co.nz
Sun Jul 19 08:10:51 UTC 2015


On 19/07/2015 3:26 p.m., Alex Rousskov wrote:
> 
> How about the following two changes?
> 
> 1. Change FilledChecklist::conn() to return NULL when conn_ is invalid.
> 2. Change the above assertion into an if statement, returning -1.
> 
> 
> If, after the above is done, somebody volunteers to replace the raw
> conn_ pointer with a CbcPointer, they should be welcomed to do that, of
> course.


SGTM. +1.

Amos


Amos


More information about the squid-dev mailing list