[squid-dev] Fwd: Heads up: cachemgr output in trunk

[Amos Jeffries]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 7/01/2015 10:44 p.m., Kinkie wrote:
> 
> Hi, something is looking weird with cachemgr output (and has been
> for a while, at least before rev 13809.
> 
> 1. ACLs are not newline-separated
> 
> acl CONNECT method  CONNECT acl Safe_ports port  80 21 443 70 210 
> 1025-65535 280 488 591 777 acl SSL_ports port  443 acl localnet
> src 10.0.0.0/8 172.16.0.0/12 192.168.0.0/16 acl arpacl arp 
> 00:26:18:7d:ac:a0 00:26:18:7d:ac:aa 00:26:18:7d:ac:af 
> 01:26:18:7d:ac:af acl to_localhost dst  ::1 0.0.0.0 127.0.0.0/8
> acl localhost src  ::1 127.0.0.1 acl manager url_regex - -i 
> (^cache_object://) +i (^https?://[^/]+/squid-internal-mgr/) acl
> all src  ::/0 follow_x_forwarded_for deny all

Incorrect dump() code for "acl" directive. The child object storing
the list values does not output \n characters as it is usually dumping
content as a child of some other object. The "acl" dumper needs to
append \n.

> 
> 2. http_access and http_port lines (oddly, not the first line) have
> an extra heading white space http_access allow arpacl http_access
> allow manager localhost http_access deny manager http_access deny
> !Safe_ports http_access deny CONNECT !SSL_ports http_access allow
> localhost http_access allow localnet http_access deny all http_port
> [::]:3128 name=3128 connection-auth=on
> 

I think this whitespace is an artifact of some dumper wrongly assuming
line-wrapping. But I've not spotted exactly where.


> 3. spurious characters before host_verify_strict 
> `5<83>{<FF>^?host_verify_strict on
> 
> There are also a couple of unexpected newlines in my sample
> output, but everything else looks OK.
> 
> Does anyone know about where this may be originating from?


Amos
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (MingW32)

iQEcBAEBAgAGBQJUrQxBAAoJELJo5wb/XPRjf08H/Alx8bqoCXGLtZ58ZeSjaOuo
fXr2MNVAZj+whywaKlUhfhzY40x7aKCKOmz8JHovQNmjggyJNmiKOMgzp9X6aHDD
8+cVjIwQ9YKD+mJgFzlu0qtUhfU1ntYPx3LhEAlxbnyiTPUcl7BiZXnaMntkHZZu
5Q/VUFnkOdvy3bHHejgq1WLTRoTPWsvdb7+sWD4KdssOVeL6X1Grb5tyJLZUeZGn
IUt+6KWGdaT8EzVbrQDHrE9b6LzrCHM7oovoBcWwwFWfRJMOCxcQbfFTWMTeQ/Yd
qUgieRTdrJ2WpFLLKLW3s5QjXelwBR/hrCUr/13MNSdluipskREgAGWi7MmblvY=
=j8NI
-----END PGP SIGNATURE-----