[squid-dev] [MERGE] Fix splay

Kinkie gkinkie at gmail.com
Fri Jan 2 12:54:18 UTC 2015


> I believe this is missing several "delete Foo;" in the ACL
> destructors. You used new() to allocate the Splay<> objects, there
> should be matching delete() at the same owner/abstraction level.
> For example:
> "
>  ACLIP::~ACLIP()
>  {
>     if (data) {
>         data->destroy(IPSplay::DefaultFree);
>         data->destroy();
>         delete data;
>      }
>  }
> "
> ... although, it would be even better if the data members could be
> made non-pointers now they are Splay<> objects. Is that easy enough to
> do in this patch ?

Well, splay doesn't have a destructor :\
I'll see if I can do something about it.

> Other than the new() / delete() issue. +1.

Ok, thanks. I'll also see about the empty lines.

-- 
    Francesco


More information about the squid-dev mailing list