[squid-dev] [PATCH] Crypto-NG: update use of random number generators

Kinkie gkinkie at gmail.com
Sun Feb 8 17:23:18 UTC 2015


Hi.
   I suggest using uint16_t instead of unsigned short int and related
macros for clarity (see
http://en.cppreference.com/w/cpp/types/integer).
I can find no other obvious issues; so if the above is covered it's +1
from me without re-review.

On Sun, Feb 8, 2015 at 6:10 PM, Amos Jeffries <squid3 at treenet.co.nz> wrote:
> C++11 brings with it a set of reasonable quality random number
> generators and tools to retrieve values for various ranges and types.
>
> This patch C++11 STL <random> features to replace the use of the
> varyingly broken, weak or non-standard functions: rand(), random(),
> lrand48(), and drand48().
>
> In the process we gain much faster and higher quality randomness in the
> auth nonces and event queue scheduling. And more "even" spread for the
> ACL random feature.
>
> Amos
>
> _______________________________________________
> squid-dev mailing list
> squid-dev at lists.squid-cache.org
> http://lists.squid-cache.org/listinfo/squid-dev
>



-- 
    Francesco


More information about the squid-dev mailing list