[squid-dev] [PATCH] mempools-nozero: turn StoreEntry into MEMPROXY_CLASS

[Alex Rousskov]

On 08/27/2015 08:58 AM, Kinkie wrote:

>   this patch turns StoreEntry into MEMPROXY_CLASS, getting rid of the
> default constructors.
>   In the process, it turns hash_link into a class, giving it a default
> constructor in order to support nonzeroing pools.
>   The old custom allocator also gave a nonstandard chunk size; that
> tweak should not be necessary anymore.

Can you explain why that tweak should not be necessary any more?


I have no objections related to the patch, but FYI:

> $ find-bad-changes.pl < /tmp/mempools-nozero-storeentry.patch 
> src/store.cc:307: Unnecessary code change of: -    mem_obj(NULL),
> src/store.cc:308:                     ... to: +    mem_obj(nullptr),


Alex.