[squid-dev] [PATCH] Coverity-fixes, part 1: EnumIterator

[Amos Jeffries]

On 27/08/2015 6:19 a.m., Alex Rousskov wrote:
> On 08/26/2015 11:04 AM, Kinkie wrote:
> 
>> v2 patch attached.
> 
> FYI: If you have missed my last email on this thread, it is archived at
> http://lists.squid-cache.org/pipermail/squid-dev/2015-August/003173.html
> 
> Alex.
> 

Also,

Please double-triple-check that your new awk code works on all files its
been processing so far. Some of them are in other sub-directories and
IIRC the reason it was not using END already was that it sometimes had
to process multiple enum types from a single file.


in src/neighbors.cc the range-for loop in the hunk @1607 should be a
WholeEnum right?



I dont see any special-case requiring ICP_END to stay in existence. All
I see is it being used to check for out-of-range values being received
in the packet opcode field.

In which case the value ICP_END itelf should be included as an invalid
value; yes? or if END is an opcode why is it not being reported in the
stats with enumEnd_ a value past it?

Or perhapse this is simply showing the lack of an explicit isItValid()
check in the API design.

Amos