[squid-dev] [PATCH] Improve support for std::uniform_*_distribution

Amos Jeffries squid3 at treenet.co.nz
Tue Aug 25 13:27:15 UTC 2015


On 26/08/2015 12:30 a.m., Kinkie wrote:
> Hi,
>   the attached patch fixes the detection and useage of
> std::uniform_*_distribution (with fallback to std::tr1::uniform_* ):
> - it implements caching on the autoconf checks
> - checks for #include <tr1/random> for future proofing
> - defines preprocessor wrappers in compat/types.h with include guards
> - uses those preprocessor wrappers. The user-visible effect is to bring
> uniform_*_distribution into the application scope.
> std::uniform_*_distribution still works but doesn't benefit from the
> portability improvements
> - implements c++11 guards against RegexPattern move operators
> - completes rule-of-five implementation in RegexPattern.
> 
> This patch still will not build, as icc 13.1 doesn't support the override
> keyword.
> More effort coming up on that.
> 

in acinclude/ax_cxx_0x_types.m4:
* please indent the contents of AC_DEFUN by 2 SP
  - that should reduce the diff line count from useless shifting


in configure.ac
 * can the header check be placed in the AC_DEFUN instead ?


in src/base/RegexPattern.h
* out of scope change
 - please commit all these changes as a separate patch
 - I need to do different portages for the regex and random stuff

+1. please commit asap.

Amos


More information about the squid-dev mailing list