[squid-dev] [PATCH] Coverity-fixes, part 1: EnumIterator

Alex Rousskov rousskov at measurement-factory.com
Mon Aug 24 19:18:52 UTC 2015


On 08/24/2015 01:09 PM, Kinkie wrote:
> I can try to look for one but it'd be completely unrelated to the main
> objective of the patch.

It is related to being able to review whether the patch objective is
worth changing Squid for, and whether the patch achieves its objective.

We can post dozens of perfect patches adding APIs that do not make Squid
better. Use cases and examples of the expected use changes are important
when it comes to APIs!


> Doing that in this patch would basically pull the whole branch in.

Do not do that in this patch if you do not think that is a good idea.
You do not have to commit those usage changes with the patch. Just show
them in a convenient-for-reviewer form (a separate attachment, a few
pasted code snippets, etc.)!

Alex.



More information about the squid-dev mailing list