[squid-dev] [PATCH] mempools-nozero part 4: debug

[Kinkie]

Merged with requested changes as r14244.

On Mon, Aug 24, 2015 at 7:10 PM, Amos Jeffries <squid3 at treenet.co.nz> wrote:

> On 25/08/2015 3:36 a.m., Kinkie wrote:
> > Hi,
> >   part 4 (of 5) patches from the mempools-nozero branch: debug
> >
> > This patch transforms Debug::OutStream into a MEMPROXY_CLASS instead of
> > rolling its own new and delete operators. The biggest changes come from
> > pulling in various Makefile.am files the necessary dependencies.
> > I've taken the chance to also rely more on Makefile variables in various
> > file-copying recipes in order to simplify them a bit.
> >
> > Patch with big context attached.
> >
>
> in src/icmp/Makefile.am:
> * "#libmem is needed for"looks like it should be up on COPIED_SOURCE
>  - I see no libmem/libmisc file reference in the list below it
>  - the libmisc is also MIA
>
>
> in test-suite/Makefile.am:
> * I woud rather the STUBS= list was one file per line now if its going
> to be wrapped at all.
>
>
> in tools/Makefile.am
> * please use alphabetical order on cachemgr__CGIEXT__SOURCES changes
>  - that will even cut the patch by 1 line.
>
> +1. with the above
>
> Amos
> _______________________________________________
> squid-dev mailing list
> squid-dev at lists.squid-cache.org
> http://lists.squid-cache.org/listinfo/squid-dev
>



-- 
    Francesco
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squid-cache.org/pipermail/squid-dev/attachments/20150824/5f46a61c/attachment.html>