[squid-dev] [PATCH] mempools-nozero part 5: stop zeroing allocated blocks

Amos Jeffries squid3 at treenet.co.nz
Mon Aug 24 17:13:19 UTC 2015


On 25/08/2015 3:43 a.m., Kinkie wrote:
> Hi,
>    this is the final patch in the mempools-nozero series (for now).
> It requires the already-merged part 1 (fix constructors) and at least part
> of part 3 (wordlist).
> 
> It:
> - implements a pass-through method in Mem::AllocatorProxy to enable
> specifying to the allocator the zeroing policy
> - extends the AllocatorProxy constructors with a parameter to predefine
> this parameter
> - sets it to "do not zero memory blocks" in MEMPROXY_CLASS
> 

in src/mem/AllocatorProxy.h the comment about non-zeroing should be
highlighted a litte more rather than hidden in whats now the middle of a
long paragraph.

I suggest adding a " *" line to make two doxygen paragraphs.


+1 with the above.

Oh, and any note about what % speedup you measured for this vs trunk
would be good for the commit message.

Amos



More information about the squid-dev mailing list