[squid-dev] [PATCH] mempools-nozero part 3: wordlist

[Amos Jeffries]

On 25/08/2015 3:30 a.m., Kinkie wrote:
> Hi,
>    this patch:
> - removes unused wordlistDup
> - implements proper constructors for wordlist, making it MEMPROXY_CLASS-safe
> - makes its destructor private to force clients to use wordlistDestroy
> instead
> - implements wordlistChopHead to support the one case in the whole codebase
> where a wordlist element was legitimately deleted.
> 
> The code looks odd, but this is an unfortunate consequence of asymmetric
> expectations on the construct/destruct side: construct side requrires C++
> semantics for MEMPROXY_CLASS, destruct side callers expect C semantics.
> 
> The code has been build- and run- tested.
> 
> Patch with big context attached.
> 

+1.

Amos