[squid-dev] [PATCH] Mempools-nozero part 1: fix constructors

Amos Jeffries squid3 at treenet.co.nz
Mon Aug 24 13:11:13 UTC 2015


On 25/08/2015 12:26 a.m., Kinkie wrote:
> Hi all,
>     this patch is the first (of six) aiming at decomposing into more
> digestible chunks the already-posted (and mostly audited) mempools-nozero
> branch.
> 
> The attached patch fixes the constructors of all MEMPROXY_CLASS users so
> that they completely initialize objects, avoiding reliance on mempools'
> zeroing behavior.
> 
> The patch has 30 lines of context, thus the big size.
> 

in src/acl/Acl.cc:
* s/NULL/nullptr/ on changes lines...


in src/acl/Acl.h:
* acl_proxy_auth_match_cache list wrapping
 - single 1-liner , or one-line-per-entry please

in src/mime.cc:
* for simplicity MimeIcon::MimeIcon(char*) should probably initialize to
nullptr, then use setName(aName); in its body.


Amos



More information about the squid-dev mailing list