[squid-dev] [PATCH] Non-zeroing mempools

Kinkie gkinkie at gmail.com
Wed Aug 19 19:28:46 UTC 2015


Hi all,
  the attached patch (a merge request from
lp:~kinkie/squid/mempools-nozero) changes MEMPROXY_CLASS so that it doesn't
zero memory before releasing it to requestors. The constructors of all
classes using that feature were checked, so that they fully initialize all
data members and thus require no zeroing.
It also changes Debug::OutStream to use MEMPROXY_CLASS instead of
new/derelete, and changes constructors to initializer lists whenever
possible and sensible (aka justified by other changes), same for dropping
HERE and adopting nullptr.
It also changes some code in Makefile.am to use make variables in place of
full paths.
The code has been run-tested (default config only), build-farm-tested and
polygraph-tested. It shows a small but noticeable performance improvement
in performance (of course, numbers are to be taken with a big grain of
salt).

When reviewing, please do not focus on formatting issues; if this patch
passes review I'll run a source-formatting before merging.

Thanks!

-- 
    Kinkie
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squid-cache.org/pipermail/squid-dev/attachments/20150819/1542fa7d/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mempools-nozero-v1.patch
Type: application/octet-stream
Size: 61707 bytes
Desc: not available
URL: <http://lists.squid-cache.org/pipermail/squid-dev/attachments/20150819/1542fa7d/attachment-0001.obj>


More information about the squid-dev mailing list