[squid-dev] [PATCH] suffix parsing and skipping

Alex Rousskov rousskov at measurement-factory.com
Fri Aug 7 23:07:47 UTC 2015


On 07/23/2015 09:27 AM, Amos Jeffries wrote:

> in SBuf.h:
> 
> * SBuf::findLastNotOf() documentation looks wrong.
>  - s/occurrences before/occurrences after/

Fixed.


> * not sure why the "TODO: rename to camelCase" still existed.
>  - probably should not be copied to the new method(s) anyhow.

Done.


I also implemented Tokenizer::parsedSize() updates for consumed suffixes
per Amos request, even though I do not think that was the right thing to
do. The XXX comment marking this API in the previous patch (that Kinkie
complained about) is now removed.


The patch has been ported to recent trunk and passes "make check" tests.
I added a few tests for the new suffix-parsing methods, mimicking the
existing prefix-parsing tests.


HTH,

Alex.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: parse-tail-t3.patch
Type: text/x-diff
Size: 18401 bytes
Desc: not available
URL: <http://lists.squid-cache.org/pipermail/squid-dev/attachments/20150807/b87cab5f/attachment-0001.patch>


More information about the squid-dev mailing list