[squid-dev] [PATCH] HttpHeader migration (coverity-fixes branch)

Alex Rousskov rousskov at measurement-factory.com
Tue Aug 4 15:12:01 UTC 2015


On 08/04/2015 05:22 AM, Kinkie wrote:
> moving away from homegrown bitfields (CBIT_TEST etc.) towards
> std::vector<bool> or std::vector<unsigned char>

There is also std::bitset.

If you care about performance, please keep in mind that we only need the
quick "is it there?" test for the field names Squid actually tests for,
not all the field names somebody may find in some RFC. If allocating
larger vectors is more expensive than a small std::bitset, and you
expect those allocations happen at runtime after warmup, then you may
want to reduce the number of field names that can be tested for.

Alex.



More information about the squid-dev mailing list